Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GasTracer #3974

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor GasTracer #3974

wants to merge 3 commits into from
+284 −21

Conversation

s2quake
Copy link
Contributor

@s2quake s2quake commented Oct 25, 2024 •
edited
Loading

Changes

  • Added Added CancelTrace method to GasTracer.

@s2quake s2quake marked this pull request as ready for review October 25, 2024 07:22
riemannulus
riemannulus reviewed Oct 25, 2024
View reviewed changes
src/Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
src/Libplanet.Action/GasMeter.cs Outdated Show resolved Hide resolved
@s2quake s2quake marked this pull request as draft October 25, 2024 10:54
@s2quake s2quake marked this pull request as ready for review October 25, 2024 12:38
riemannulus
riemannulus previously approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But, Could you make the test about GasTracer.IsTraceCancelled?

@s2quake
Copy link
Contributor Author

s2quake commented Oct 26, 2024

LGTM! But, Could you make the test about GasTracer.IsTraceCancelled?

Test code for GasTracer.IsTraceCancelled has been committed. 6d4da2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limebell limebell Awaiting requested review from limebell

@OnedgeLee OnedgeLee Awaiting requested review from OnedgeLee

@greymistcube greymistcube Awaiting requested review from greymistcube

@riemannulus riemannulus Awaiting requested review from riemannulus

At least 1 approving review is required to merge this pull request.

Assignees

@s2quake s2quake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s2quake @riemannulus