-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GasTracer #3974
Open
s2quake
wants to merge
3
commits into
main
Choose a base branch
from
refactor/gas-tracer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor GasTracer #3974
+284
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 25, 2024 07:08
680df7e
to
efd4aa4
Compare
s2quake
requested review from
limebell,
OnedgeLee,
riemannulus and
greymistcube
October 25, 2024 07:10
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 25, 2024 07:11
efd4aa4
to
7b8b6ad
Compare
riemannulus
reviewed
Oct 25, 2024
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 25, 2024 10:57
7b8b6ad
to
129b0cb
Compare
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 25, 2024 12:34
129b0cb
to
7d041d1
Compare
riemannulus
previously approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But, Could you make the test about GasTracer.IsTraceCancelled
?
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 26, 2024 10:56
7d041d1
to
336d46c
Compare
s2quake
force-pushed
the
refactor/gas-tracer
branch
from
October 26, 2024 11:00
336d46c
to
07a95f0
Compare
Test code for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CancelTrace
method toGasTracer
.