Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts #215

justb4 · 2013-10-30T15:42:46Z

Although issue #206 has been closed, I would like you to reconsider, also taken into the account the fix in the commits (the second is to undo a change in WFSProtocolProxy that went in by accident).

As I see it:

the original code changes a global var: OpenLayers.Renderer.defaultSymbolizer. This affects not only OLEditor but any other component that uses the defaultSymbolizer
by changing the name into OpenLayers.Renderer.defaultSymbolizerGXP (see commit) and using it in all assignments for defaults in GXP, IMO the SLD defaults are respected

…ent in WMSStylesDialog

…tor into StylesDialog.js ABC

… DFT for Labels

…nd allow 3-digit colors in ColorField

…ught by self-updating VectorLegend)

…s-browser, fixes IE-problem in ColorField

…ing and localization

…d fix text opacity edit

…ExJS Template

…(image loaoding, TMS abstract attr)

…S and WMS

…rs and Legends

…r Styling for WFS layers

…AddLayersPanel

… via defaultSrs config options

CatalogueSearchPanel - Metadata popup window in IE doesn't show scrollbars

…atureType w GET

Same as for OLE, Add Croatian translation. Lijep ti dan želim! :-)

Add Overviewmap control to gxp

@dracic

@dracic thanks for your hard work! Fix StylesDialog localization error & add missing strings for gxp

and pulled in! Fix hr.js

… layer after adding it to the map

@deduikertjes

@deduikertjes bedankt! Goed dat dit ook configureerbaar is. Added config zoomToLayer

Fix some i18n quirks in the AddLayers.js module

justb4 added 30 commits October 30, 2013 16:21

fix for issue planetfederal#206 : Global OL defaultSymbolizer assignm…

b896b7e

…ent in WMSStylesDialog

revert WFSProtocolProxy.js to original

00d37ad

crude impl for issue#216 - Vector Layer Styling

0b9b0b7

Merge remote-tracking branch 'upstream/master'

e091852

issue planetfederal#216 - Vector Layer Styling - refine and and refac…

bf12ae3

…tor into StylesDialog.js ABC

issue planetfederal#216 - less text widgets when not required and WFS…

4c3f540

… DFT for Labels

issue planetfederal#216 - colorpickerwin: close when color selected a…

29649a2

…nd allow 3-digit colors in ColorField

issue planetfederal#216 - emit stylechanged event for Layer (to be ca…

001f15d

…ught by self-updating VectorLegend)

issue planetfederal#216 - use charAt() to access chars in string cros…

16fb06b

…s-browser, fixes IE-problem in ColorField

issue planetfederal#216 - improvements in selected features when styl…

9369cbf

…ing and localization

Merge remote-tracking branch 'upstream/master'

1cb15bb

issue planetfederal#216 - Text label editing: enable Text Fieldset an…

c749071

…d fix text opacity edit

issue planetfederal#216 - fix per-layer redraw wtih styling

c9caa74

issue planetfederal#216 - disable unneeded buttons in rule fieldset

edb3f7b

issue planetfederal#216 - feture redrawing for custom style issue solved

0b47715

issue planetfederal#229 - locale file hu.js for Hungarian lcoale

6f30308

issue planetfederal#216 - various UX fixes and form initializations

66d03b3

set OL WMSLayer field queryable from WMS Capabilities

965d4ff

add removeActionText config option to RemoveLayer

120ec15

issue planetfederal#230 - first stab at improved AddLayers GUI using …

2f60c30

…ExJS Template

issue planetfederal#230 - enhancing AddLayers GUI using ExJS Template

2c54b6e

issue planetfederal#230 - enhancing AddLayers GUI for Layer previews

b3d834d

issue planetfederal#230 - enhancing AddLayers GUI for Layer previews …

7bc2605

…(image loaoding, TMS abstract attr)

issue planetfederal#230 strategies to fetch preview map images for TM…

7ab722b

…S and WMS

issue planetfederal#230 - add WFSSource for AddLayers (first stab)

7713bd2

issue planetfederal#230 - WFSSource for AddLayers - random Layer colo…

e725701

…rs and Legends

issue planetfederal#230 - WFSSource for AddLayers - allow Vector Laye…

8cb658c

…r Styling for WFS layers

issue planetfederal#230 - CSS style for sort icon added

0fe3217

issue planetfederal#230 - added search and sort toolbar functions to …

f77421d

…AddLayersPanel

issue planetfederal#230 - refined tooltip and WFS projection options,…

8f02fdd

… via defaultSrs config options

justb4 and others added 30 commits September 16, 2014 17:35

issue 324 - cater for WMS urls without ? in the end - again fix

b78febe

test commit to justb4.gxp

362af23

test commit to justb4.gxp

08879a7

Update CatalogueSearchPanel.js

4186f28

Merge pull request #2 from dracic/master

f2a4eab

CatalogueSearchPanel - Metadata popup window in IE doesn't show scrollbars

extend removelayer to enable for dynamically added layers only

71449b1

Merge branch 'master' of github.com:justb4/gxp

0262a92

extend LayerProperties to enable for dynamically added layers only

4c51e85

extend OpacitySlider to enable for dynamically added layers only

d3a9c5c

test git connection for submodule in Heron

7b4518c

fix strange behaviour for ns= (now ns:) NS encoding in WFS DescribeFe…

9d75e66

…atureType w GET

#324 NPE on certain selections

71544e8

Add Croatian translation

9c90de8

Merge pull request #3 from dracic/master

4aa84b5

Same as for OLE, Add Croatian translation. Lijep ti dan želim! :-)

#3 added missing comma at line 400 in hr.js

c72b68f

Added OverviewMap plugin and two demo examples of the plugin

d71f95f

Added OverviewMap.js to loader.js

44215c3

Merge pull request #4 from dracic/overviewmap

da7cb09

Add Overviewmap control to gxp

Fix StylesDialog localization error for hr.js

3433c00

Fix StylesDialog localization error for other languages

63db3d3

Add missing strings for AddLayers.js

abbe06b

Add missing prototype and strings for CatalogueSearchPanel (en, hr)

f0f4ecf

Merge pull request #5 from dracic/master

6e85407

@dracic thanks for your hard work! Fix StylesDialog localization error & add missing strings for gxp

Fix hr.js

e2943fa

Merge pull request #6 from dracic/master

fb421e3

and pulled in! Fix hr.js

Added config zoomToLayer to set if the map zooms to the extent of the…

f2b095c

… layer after adding it to the map

Merge pull request #7 from deduikertjes/master

fd6627e

@deduikertjes bedankt! Goed dat dit ook configureerbaar is. Added config zoomToLayer

Fix some i18n quirks in the AddLayers.js module

2736600

Fix i11n quirks

5120270

Merge pull request #8 from wolwin/master

3560591

Fix some i18n quirks in the AddLayers.js module

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts #215

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts #215

justb4 commented Oct 30, 2013

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts #215

Are you sure you want to change the base?

Fix for issue #206 Global OL defaultSymbolizer assignment in WMSStylesDialog creates conflicts #215

Conversation

justb4 commented Oct 30, 2013