Add UseRdonly option to the airbyte connector #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notfelineit any chance we can get this reviewed and merged? |
|
@Anders-PlanetScale sorry for the delay - I'll review today! |
notfelineit
reviewed
Sep 20, 2024
Co-authored-by: Frances Thai <[email protected]>
notfelineit
reviewed
Sep 20, 2024
| @@ -171,7 +171,9 @@ func (p PlanetScaleEdgeDatabase) Read(ctx context.Context, w io.Writer, ps Plane | |||
| ) | |||
|
|
|||
| tabletType := psdbconnect.TabletType_primary | |||
| if ps.UseReplica { | |||
| if ps.UseRdonly { | |||
| tabletType = psdbconnect.TabletType_batch | |||
There was a problem hiding this comment.
Confirmed that this will be mapped to topodatapb.TabletType_RDONLY by our edge gateway.
notfelineit
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to add a Use Rdonly option to the airbyte connector. I am not a go person so someone please review.