Chore: Swap Off of Deprectated MarkdownRender.renderMarkdown to MarkdownRender.render
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e warnings about them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I noticed that
MarkdownRender.renderMarkdownis marked as deprecated. So I decided to move to the recommended replacement. It looks to work, but did require changing a little of how the internals work to pass around an instance of the app a little more. This should make it so we don't get caught in any nasty issue with the logic being removed entirely and us getting caught flat footed.Also adds a warning to linting to hopefully realize when deprecated functions are used in the code.