Lock while generating certificates or refreshing tokens #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
force-pushed
the
auth-lock
branch
from
d8f61fb to
62147b4
Compare
pjcdawkins
commented
Nov 27, 2023
pjcdawkins
force-pushed
the
auth-lock
branch
4 times, most recently
from
4e22f82 to
b9c4945
Compare
This guards against most of the race condition bugs that occur while running
multiple instances of the CLI in parallel. It doesn't fix all of them.
This behavior can be disabled using the environment variable
`{PREFIX}DISABLE_LOCKS`, or the config entry `api.disable_locks`.
pjcdawkins
force-pushed
the
auth-lock
branch
from
b9c4945 to
030b3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guards against most of the race condition bugs that occur while running
multiple instances of the CLI in parallel. It doesn't fix all of them.