Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds guides for WordPress Vanilla and WordPress Bedrock #4340

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gilzow
Copy link
Collaborator

@gilzow gilzow commented Jan 14, 2025

Why

Adds guides for WordPress Vanilla and WordPress Bedrock

What's changed

  • Creates a new section for WordPress
  • Adds an index for the new section
  • Moves existing guide (Composer) inside this section, renaming the file to composer.md
  • Adds page in this section for WordPress Vanilla (vanilla.md)
  • Adds page in this section WordPress Bedrock (bedrock.md).

The one thing I can't figure out is the sidebar nav. For some reason, i've bumped Laravel out of the regular PHP section into a separate, but duplicate PHP section 😖

image

Also, the index page for the WordPress section probably needs work?

Where are changes

Updates are for:

  • platform (sites/platform templates)
  • upsun (sites/upsun templates)

To make the location writable, set up [a mount](/create-apps/app-reference/single-runtime-image.md#mounts). To do so,
locate the `mounts:` section that is commented out, and update it as follows:

1. Create the location.</br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a numbered point if it's the only step? I think it might be better to make it a bullet point or sub-heading within the second point. I only mention this because I found just momentarily confusing when I saw a point number one, after already passing step number two. Then I expected a second point, but there was none, so jumping to the third step felt confusing for a bit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. I think i originally had more steps and then moved them elsewhere, and then forgot to remove the numbering here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change this and push the fix

export DB_SCHEME="$MARIADB_SCHEME"
export DATABASE_URL="${DB_SCHEME}://${DB_USERNAME}:${DB_PASSWORD}@${DB_HOST}:${DB_PORT}/${DB_PATH}"
```
To configure the remaining environment variables WordPress needs to run smoothly, follow these steps.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To configure the remaining environment variables WordPress needs to run smoothly, follow these steps.
To configure the remaining environment variables that WordPress needs to run smoothly, follow these steps.


Before you start, check out the [{{% vendor/name %}} demo app](https://console.upsun.com/projects/create-project)
and the main [Getting started guide](/get-started/here/_index.md).
They provide all the core concepts and common commands you need to know before using the following materials.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
They provide all the core concepts and common commands you need to know before using the following materials.
These resources provide all the core concepts and common commands you need to know before using the following materials.

allow: true
expires: 1w
```
**Note**: If you changed the name of the directory at step 1.4 you'll need to update the `root` property to match for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: If you changed the name of the directory at step 1.4 you'll need to update the `root` property to match for
{{< note theme="info" >}}
If you changed the name of the directory at step 1.4 you'll need to update the `root` property to match for both locations.
{{< /note >}}

source: storage
source_path: "uploads"
```
4. Some tasks need to be performed after the images for our application are built, but before the newly built
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just echoing the same sentiment I had with the previous suggestion I made for this sentence structure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants