Test out fetch-with-keepalive on plausible.io #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch with keepalive is a [widely-supported](https://developer.mozilla.org/en-US/docs/Web/API/Request/keepalive) which indicates whether the browser will keep the associated request alive if the page that initiated it is unloaded before the request is complete. We're hoping it will improve event capture rates for `pageleave` and `pageview` events when the user closes the tab To use it, we also need to start using `fetch` (with fallback to xhr). For extra safety, we will only deploy this on `plausible.io` initially. This will ensure that if there are issues we will be able to react without affecting any other customers. TODO after this PR: - [ ] Companion docs PR - [ ] Purge bunny cache - [ ] Make fetch the default request method without data-property
macobo
added a commit
to plausible/website
that referenced
this pull request
Jan 23, 2025
Companion PR to plausible/analytics#5005 Haven't tested locally!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch with keepalive is a
widely-supported which indicates whether the browser will keep the associated request alive if the page that initiated it is unloaded before the request is complete.
We're hoping it will improve event capture rates for
pageleaveandpageviewevents when the user closes the tabTo use it, we also need to start using
fetch(with fallback to xhr).For extra safety, we will only deploy this on
plausible.ioinitially. This will ensure that if there are issues we will be able to react without affecting any other customers.I tested this locally by adding temporary logging to the script:
Companion PR: plausible/docs#579
TODO after this PR: