Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up rollup version #6995

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Up rollup version #6995

wants to merge 3 commits into from

Conversation

LeXXik
Copy link
Contributor

@LeXXik LeXXik commented Sep 27, 2024

Fixes GHSA-gcx4-mw62-g8wm

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@@ -1,7 +1,7 @@
{
"name": "playcanvas",
"version": "2.1.0-dev",
"lockfileVersion": 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're on an old version of NPM. The package-lock.json has been bumped down to 2 from 3. This adds about 7.500 lines to the file!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, updated npm to 10.8.3 and getting warnings now. Do you have the same? What version do you use?

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using 9.7.1. But those warnings are fine. The eslint-plugin-import team are working to add support for ESLint 9. I think they'll be done in a week or two. Then, those warnings will go away.

@LeXXik
Copy link
Contributor Author

LeXXik commented Sep 27, 2024

Getting many tasks failing :/ Is it something I should fix on my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants