Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Cube extra #7081

Merged
merged 12 commits into from
Jan 28, 2025
Merged

View Cube extra #7081

merged 12 commits into from
Jan 28, 2025

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Oct 31, 2024

  • Ported view cube from supersplat to extras
  • Refactored and added customization to components

API

colorX: Color;
colorY: Color
colorZ: Color;
colorNeg: Color;
radius: number;
textSize: number;
lineThickness: number;
lineLength: number;

Preview

image

@kpal81xd kpal81xd changed the title [WIP] View Cube extra [BETA] View Cube extra Oct 31, 2024
@kpal81xd kpal81xd marked this pull request as draft October 31, 2024 11:49
@kpal81xd kpal81xd self-assigned this Oct 31, 2024
@kpal81xd kpal81xd marked this pull request as ready for review October 31, 2024 11:50
@kpal81xd kpal81xd marked this pull request as draft November 12, 2024 10:47
@kpal81xd kpal81xd marked this pull request as ready for review January 27, 2025 18:37
@kpal81xd kpal81xd changed the title [BETA] View Cube extra View Cube extra Jan 27, 2025
@kpal81xd kpal81xd requested a review from a team January 27, 2025 18:37
@@ -0,0 +1,457 @@
import { EventHandler } from '../../core/event-handler.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should view-cube.js really be in the gizmo folder? It's not technically a gizmo (doesn't subclass from it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it in there since it is kind of a gizmo since it allows you to move the camera in the scene but doesnt extend the gizmo class itself. Also the folder contains more than just the raw gizmo classes themselves.

@kpal81xd kpal81xd merged commit e692b5e into main Jan 28, 2025
7 checks passed
@kpal81xd kpal81xd deleted the view-cube branch January 28, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants