This repository has been archived by the owner on Feb 9, 2019. It is now read-only.
Update readme.md on how to setup play 2.4.2 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Play 2.4.2, the current readme causes an exception to be thrown upon setting up @Inject on JedisPool. The correct dependency is play-plugin-redis 2.4.1 see playframework#156 and playframework#157
|
Hi @ronaldwidha, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
I've signed the agreement. |
| and you'll probably need to add this resolver too to resolve Sedis (see [issue](https://github.com/typesafehub/play-plugins/issues/141)): | ||
| ```resolvers += "google-sedis-fix" at "http://pk11-scratch.googlecode.com/svn/trunk"``` | ||
|
|
||
| * Most likely you will want to manage your dependency using guice so that you can inject JedisPool to classes other than the Play controllers e.g. your data access objects. To enable guice add the following to your dependencies: | ||
| ```"com.google.inject.extensions" % "guice-servlet" % "4.0"``` |
There was a problem hiding this comment.
guice-servlet shouldn't be needed - Play depends on Guice out of the box, you shouldn't need an explicit dependency on it, and you definitely shouldn't need to bring in the servlet API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme.md is out of date and causing specifically 2 known issues discussed in the following threads:
In summary, in Play 2.4.2, the current readme causes an exception to be thrown upon setting up @Inject on JedisPool. The correct dependency is play-plugin-redis 2.4.1 (instead of 2.4.0).
Also, since all other dependencies need to participate in the dependency injection to obtain JedisPool via @Inject, I believe it is beneficial for new users to have this piece of information explicitly called out as part of the getting started step.