Fix subprocess call arguments for getting required services

plesk · Mar 19, 2024 · 74cdb33 · 74cdb33
1 parent 3fbca95
commit 74cdb33
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/systemd.py b/src/systemd.py
@@ -25,11 +25,16 @@ def is_service_active(service: str):
 
 
 def get_required_services(service: str) -> typing.List[str]:
-    res = subprocess.run([SYSTEMCTL_BIN_PATH, 'cat', service], capture_output=True, text=True)
-    output = res.stdout.strip()
+    res = subprocess.run(
+        [SYSTEMCTL_BIN_PATH, 'cat', service],
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        check=True,
+        universal_newlines=True
+    )
 
     required_services = []
-    for line in output.split('\n'):
+    for line in res.stdout.splitlines():
         if line.startswith('Requires='):
             required_services = line.split('s=')[1].split()
             break