Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play show theme music in the background #205

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

pannal
Copy link
Contributor

@pannal pannal commented Jun 9, 2018

GHI (If applicable): #2, rewrite of #204

Description:

Plays the current episode's show theme music, or in case of a library-show-visit, the show's theme music.

Adds options for that (off by default) and a volume slider for the theme volume.

Better background music handling approach; PlexPlayer now handles that itself, together with BGMPlayerHandler.

Checklist:

  • I have based this PR against the develop branch

@ruuk ruuk self-assigned this Jun 10, 2018
@ruuk
Copy link
Contributor

ruuk commented Jun 12, 2018

Nice changes. Setting looks good. Bonus points for ListSetting base class 😄.

A couple of things I noticed. The first was that if background music is playing and you are on the home screen, you can't navigate to the header bar. The second (which probably makes the first thing irrelevant) was that we still need to only have BG music playing within the context of a show. So that pretty much means that the only screens that will have BG music will be the show screen and the episodes screen.

So for example if you open a show, BG music. Click a season, BG music continues. Go back to the show, BG music continues. Exit the show, BG music stops.

@pannal
Copy link
Contributor Author

pannal commented Jun 12, 2018

Implemented all that, as well as proper handling for related shows, e.g.: go to a related show, its theme plays, go back to the show/episode you came from, related show theme stops. The current one also doesn't re-start when coming from a related show, that would make it a bit weird.

Shouldn't the theme music stuff be default on?

@pannal
Copy link
Contributor Author

pannal commented Jun 20, 2018

Don't merge this yet. When dealing with slower devices or connections, this blocks the interface. I at least need to look into deferring the playback. If that's how it has to be, that's OK with me, if it's by design and not necessarily fixable.

But I have to try.

@pannal
Copy link
Contributor Author

pannal commented Jul 4, 2018

This should be mergable now.

@pannal
Copy link
Contributor Author

pannal commented Aug 13, 2018

Rebased onto develop

@pannal
Copy link
Contributor Author

pannal commented Aug 28, 2018

Playback is deferred, but depending on the platform, starting music playback can still block the interface for a short while - I guess that's Kodi and we can't do anything about that.

@pannal
Copy link
Contributor Author

pannal commented Aug 28, 2018

Rebased

@ruuk ruuk force-pushed the develop branch 3 times, most recently from 78f9acc to 126aaba Compare August 31, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants