-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add horizontal pagination for views #243
base: develop
Are you sure you want to change the base?
Conversation
Possible followup PR:
|
Found an off by one. Fixing it tomorrow. |
78f9acc
to
126aaba
Compare
Good to go. |
fe28f55
to
b055ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except I think it would be better if we keep some of the current items when you page, so you have a page size and window i.e. if the window size is 16 and you had 8 and you added 8, 16 would be showing. If you add 8 more you take 8 off the beginning and have still a window of 16 showing. This would allow correcting the list jump after paging by first selecting an item in the wrong direction and then the correct item so that the focus position in the end remains on either the right or the left depending on where it was before the page.
I've added an initialPageSize attribute, which is set to 18, and increased the orphan count to 8, so an initial load would not paginate for 26 items. Afterwards it continues with pages of 8 with an orphan size of 8 (at the beginning or end of the list). |
3dbb608
to
4512a14
Compare
@ruuk we should probably still set a lower page size for related items and extras, as those requests take considerably longer. I'd go with 8+4 in those cases. |
… the initial page
…et progress image on watched status changed in list
Commit 8114d11 is semi-related; it depends on this PR, though. |
GHI (If applicable): #
Description:
Known issues:
Checklist: