Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing async iterable<T> type #85

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lucacasonato
Copy link

@lucacasonato lucacasonato commented Mar 25, 2024

Ref whatwg/webidl#1397

DO NOT LAND UNTIL SPEC CHANGE IS LANDED

self.async_iterable[0].define_markup(generator)
self.async_iterable[1].define_markup(generator)
generator.add_text(self._open_type)
self.type.define_markup(generator)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.type.define_markup(generator)
generator.add_type(self.type)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I had copied this from the self.record branch.

@plinss
Copy link
Owner

plinss commented Mar 25, 2024

Thanks for the PR, can you also update the test-expected.txt file? (See CONTRIBUTING.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants