Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newParamAddedInSpeakApi #267

Merged
merged 3 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [5.38.1](https://github.com/plivo/plivo-java/tree/v5.38.1) (2023-12-19)
**Feature - Added params for Speak API**
- Added params 'type' for Speak APIs

## [5.38.0](https://github.com/plivo/plivo-java/tree/v5.38.0) (2023-11-30)
**Feature - Added params for GET and LIST Campaign API**
- Added params 'vertical', 'campaign_alias' for GET and LIST Campaign APIs
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If you are using Maven, use the following XML to include the Plivo SDK as a depe
<dependency>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.38.0</version>
<version>5.38.1</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion pom.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Written manually.

version=5.38.0
version=5.38.1
groupId=com.plivo
artifactId=plivo-java

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.38.0</version>
<version>5.38.1</version>
<name>plivo-java</name>
<description>A Java SDK to make voice calls &amp; send SMS using Plivo and to generate Plivo XML</description>
<licenses>
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/plivo/api/models/call/Call.java
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ public static CallPlayDeleter playStopper(String callUuid) {
return new CallPlayDeleter(callUuid);
}

public static CallSpeakCreator speaker(String callUuid, String text) {
return new CallSpeakCreator(callUuid, text);
public static CallSpeakCreator speaker(String callUuid, String text, String type) {
return new CallSpeakCreator(callUuid, text, type);
}

public static CallSpeakDeleter speakStopper(String callUuid) {
Expand Down Expand Up @@ -212,8 +212,8 @@ public CallPlayDeleter playStopper() {
return new CallPlayDeleter(callUuid);
}

public CallSpeakCreator speaker(String text) {
return new CallSpeakCreator(callUuid, text);
public CallSpeakCreator speaker(String text, String type) {
return new CallSpeakCreator(callUuid, text, type);
}

public RequestDeleter canceller() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@ public class CallSpeakCreator extends VoiceCreator<CallSpeakCreateResponse> {

private final String id;
private final String text;
private final String type;
private String voice;
private String language;
private LegSpecifier legs;
private Boolean loop;
private Boolean mix;

public CallSpeakCreator(String id, String text) {
public CallSpeakCreator(String id, String text, String type) {
this.id = id;
this.text = text;
this.type = type;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/plivo/api/CallTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public void callSpeakCreateShouldWork() throws Exception {
expectResponse("liveCallSpeakCreateResponse.json", 202);
final String callId = "callId";

Call.speaker(callId, "test")
Call.speaker(callId, "test", "text")
.speak();

assertRequest("POST", "Call/%s/Speak/", callId);
Expand All @@ -356,7 +356,7 @@ public void callSpeakCreateWithClientShouldWork() throws Exception {
expectResponse("liveCallSpeakCreateResponse.json", 202);
final String callId = "callId";

Call.speaker(callId, "test")
Call.speaker(callId, "test", "text")
.client(client)
.speak();

Expand Down
Loading