do not remove the src folder when bulding the docker image #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! Thank you! |
|
@Fosten I have updated the PR with the other half. Can you check if it works correctly? |
|
LGTM. One last thing, however. Issue #109 is related. |
|
Ah, I finally found what you say! With the pnpm-workspaces.yml changes what we get is to be able to have addons that follow the new structure handled by mrs-developer |
|
Awesome. I believe that should be all you need. I applied these fixes to my cookieplone projects a few weeks ago, so I was aware of the gotchas. There may be a more graceful way to do it, but wanted to share a solution. Thanks for writing the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we remove the src folder, the packages that we may have installed through sources in mx.ini will not be available.