Improve GitLab support #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erral What's the status of this one? I'd like to include it, but I can't easily test it myself. |
|
I am polishing the configuration file and doing some more tests.
I want to finish this later this week.
|
|
@stevepiercy can you review the documentation I added in the |
|
I have tested this on gitlab, with the following result:
|
stevepiercy
requested changes
Nov 8, 2024
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
project/{{ cookiecutter.__folder_name }}/devops/README-GITLAB.md
Outdated
Show resolved
Hide resolved
stevepiercy
approved these changes
Nov 11, 2024
|
@erral Could you sync this with the main branch? |
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
erral
force-pushed
the
erral-gitlab-improvements
branch
from
a212489 to
a20657d
Compare
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I bring back GitLab CI/CD support with the following features:
Add a question whether to use GitLab based deployment. If so, add a
.gitlab-ci.ymlfile that will add the required job pipelines which check, test, build, release and deploy the containers.I have slightly changed the generated docker image names only when GitLab deployment is enabled because of GitLab peculiarities: in a single GitLab repo you can save different docker files, but their name must match the structure gitlab_url/gitlab_username/project_slug/docker_image/variant so, instead of having registry.gitlab.com/codesyntax/project-backend we are having registry.gitlab.com/codesyntax/project/backend (- vs. /)
I am open to discuss the release procedure stated in the CI file, which I tried to copy from the GHA procedure. But we can discuss or change it later too.