added function get_allow_discussion_value

news/1674.bugfix

@@ -0,0 +1 @@
+Added the function `get_allow_discussion_value(context, request)`. It returns `True` if discussion is allowed, or `False` if not, based on the enabled status of the `conversation_view` adapter. @Akshat2Jain

src/plone/restapi/serializer/dxcontent.py

@@ -39,6 +39,14 @@
     WorkingCopyInfo = None
 
 
+def get_allow_discussion_value(context, request, result):
+    # This test is to handle the plone.app.discussion not being installed situation
+    if "allow_discussion" in result:
+        result["allow_discussion"] = getMultiAdapter(
+            (context, request), name="conversation_view"
+        ).enabled()
+
+
 @implementer(ISerializeToJson)
 @adapter(IDexterityContent, Interface)
 class SerializeToJson:
@@ -125,9 +133,7 @@ def __call__(self, version=None, include_items=True):
         if target_url:
             result["targetUrl"] = target_url
 
-        result["allow_discussion"] = getMultiAdapter(
-            (self.context, self.request), name="conversation_view"
-        ).enabled()
+        get_allow_discussion_value(self.context, self.request, result)
 
         return result
 

src/plone/restapi/serializer/site.py

@@ -23,6 +23,7 @@
 from zope.interface import Interface
 from zope.schema import getFields
 from zope.security.interfaces import IPermission
+from plone.restapi.serializer.dxcontent import get_allow_discussion_value
 
 import json
 
@@ -121,6 +122,8 @@ def __call__(self, version=None):
             for brain in batch
         ]
 
+        get_allow_discussion_value(self.context, self.request, result)
+
         return result
 
     def check_permission(self, permission_name, obj):

src/plone/restapi/tests/test_dxcontent_serializer.py

@@ -576,17 +576,6 @@ def test_allow_discussion_fti_disallows_allows_global_enabled_but_instance_allow
         self.assertIn("allow_discussion", obj)
         self.assertEqual(True, obj["allow_discussion"])
 
-    def test_allow_discussion_global_enabled_but_instance_has_no_discussion_behavior(
-        self,
-    ):  # noqa
-        registry = queryUtility(IRegistry)
-        settings = registry.forInterface(IDiscussionSettings, check=False)
-        settings.globally_enabled = True
-
-        obj = self.serialize()
-        self.assertIn("allow_discussion", obj)
-        self.assertEqual(False, obj["allow_discussion"])
-
 
 class TestDXContentPrimaryFieldTargetUrl(unittest.TestCase):
     layer = PLONE_RESTAPI_DX_INTEGRATION_TESTING