Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serializer block with anchors, remove trailing slash before the anchor #1748

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

sneridagh
Copy link
Member

@davisagli we overlooked this one :( the roundtrip was bugged because of the trailing slash. Please take a look at the regex, if it's fine like this.

@sneridagh sneridagh requested a review from davisagli February 15, 2024 12:15
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 2b6d47a
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65ce77a045e60e00089d0f5b

@mister-roboto
Copy link

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@sneridagh
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However I'd like @davisagli to have a second look at it.

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli
Copy link
Member

I added a related fix for the deserializer too. Checking what jenkins says...

@davisagli davisagli merged commit 48025e8 into main Feb 15, 2024
25 checks passed
@davisagli davisagli deleted the fixserializeradditionalslash branch February 15, 2024 21:56
@tisto
Copy link
Member

tisto commented Feb 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants