Support for plone.app.discussion as core add-on #1781
Conversation
jensens
commented
May 15, 2024
jensens
commented
- Turn usage/endpoints of plone.app.discussion features into optional features: ZCML conditions and optionla imports.
- Fix tests to pull in plone.app.discussion explicitly
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/source/endpoints/comments.md
Outdated
| @@ -9,7 +9,12 @@ myst: | |||
|
|
|||
| # Comments | |||
|
|
|||
| Plone offers to users a feature to post comments on any content object with `plone.app.discussion`. | |||
| ```{note} | |||
There was a problem hiding this comment.
I created a PR to unify instructions and which can be referenced here and in the plone.restapi upgrade guide, but it needs details.
Let's change this entire note block with the following. Would you please also duplicate it in the plone.restapi upgrade guide as part of this PR?
```{versionchanged} 6.1
Discussion is disabled by default in Plone 6.1 and later.
To enable discussion, see the Plone 6.1 upgrade guide section {ref}`backend-upgrade-plone-v61-discussion-label`
```
There was a problem hiding this comment.
I think this is more for the Plone 6.1 upgrade guide, since it is not because of RestAPI. I have no good idea how to describe it there nor is it a breaking change for RestAPI.
I would add a section to the https://github.com/plone/documentation/blob/6.0/docs/backend/upgrading/version-specific-migration/upgrade-to-61.md page.
Whats do you think?
There was a problem hiding this comment.
I was way ahead of you in https://github.com/plone/documentation/pull/1666/files 😁
I think that references to the main docs are not required, but they would be a good thing to do. Imagine someone jumping into the REST API docs, and there is no note about this change. sad trombone
jensens
force-pushed
the
pa-discussion-coreaddon
branch
2 times, most recently
from
5e89902 to
79ef012
Compare
Co-authored-by: Steve Piercy <[email protected]>
jensens
force-pushed
the
pa-discussion-coreaddon
branch
from
79ef012 to
b9944fd
Compare
jensens
force-pushed
the
pa-discussion-coreaddon
branch
from
e973bc4 to
972e74b
Compare
jensens
force-pushed
the
pa-discussion-coreaddon
branch
from
972e74b to
a274cbe
Compare
|
@jenkins-plone-org please run jobs |
Co-authored-by: Steve Piercy <[email protected]>
|
@jenkins-plone-org please run jobs |
