Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docs check against Python 3.12 #1794

Merged
merged 5 commits into from
Jun 16, 2024
Merged

Run docs check against Python 3.12 #1794

merged 5 commits into from
Jun 16, 2024

Conversation

tisto
Copy link
Member

@tisto tisto commented Jun 15, 2024

No description provided.

@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify Netlify
Copy link

netlify bot commented Jun 15, 2024 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 66068ed
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/666ec33b4221bb0008fafa3e

@davisagli
Copy link
Member

@tisto I added the changelog for you and updated a couple more lines that still said 3.9

davisagli
davisagli approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming CI passes

@tisto
Copy link
Member Author

tisto commented Jun 16, 2024

@davisagli thank you David!

@tisto
Copy link
Member Author

tisto commented Jun 16, 2024

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

No need to run this on Jenkins, right? The changed files are not used there.

@tisto tisto merged commit fd222a1 into main Jun 16, 2024
28 checks passed
@tisto tisto deleted the docs-py3.12 branch June 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisto @mister-roboto @davisagli @mauritsvanrees