Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a @userschema/registration endpoint #1874

Merged
merged 16 commits into from
Feb 2, 2025
Merged

Conversation

erral
Copy link
Member

@erral erral commented Jan 30, 2025

Fixes #1873


📚 Documentation preview 📚: https://plonerestapi--1874.org.readthedocs.build/

@erral erral requested a review from ionlizarazu January 30, 2025 14:11
@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Jan 30, 2025

@jenkins-plone-org please run jobs

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed only the docs and news, and briefly scanned the code. Per @davisagli's comment, some refactoring of the names of things in the code is needed. I'll review that after refactor, instead of flooding a review with dozens of line-by-line suggestions.

@erral erral changed the title feat: add a @registration-userschema endpoint feat: add a @userschema/registration endpoint Jan 31, 2025
@erral
Copy link
Member Author

erral commented Jan 31, 2025

@jenkins-plone-org please run jobs

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more refactoring to put username before registration, and a sprinkling of MyST on the change log. Then I think it's good to go.

I'd like a technical review from one of our colleagues, too. I'm not yet confident enough with this package.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral
Copy link
Member Author

erral commented Jan 31, 2025

@jenkins-plone-org please run jobs

MohammadBinAftab added a commit to MohammadBinAftab/plone.restapi that referenced this pull request Feb 1, 2025
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @erral!

@davisagli
Copy link
Member

@robgietema FYI, we are adding a variation of the @userschema endpoint with a different set of fields for the registration form.

@davisagli davisagli merged commit bc29368 into main Feb 2, 2025
20 of 24 checks passed
@davisagli davisagli deleted the erral-issue-1873 branch February 2, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Userschema for registration vs. userschema for user profile
4 participants