-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tinymce UI css updates #345
base: master
Are you sure you want to change the base?
Conversation
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Had time to dig more into this. Turns out, that the internal
So theres a problem here, because if you use a Diazo based theme with OTOH if your theme doesn't configure the CSS in Do not know how to proceed here, but I mark this as draft right now. /cc @MrTango |
Thinking more about this we could say that it's more a documentation problem. Tell the integrators how to get their styles into tiny either with configured |
TinyMCE
<iframe/>
implementation has missing CSS definitions of plone content. For example if you align an image on the right you see it in the view mode but not when editing it in TinyMCE. This PR extends thetinymce-ui-content.css
with thebarceloneta/base
CSS via SCSS.