Skip to content

Commit

Permalink
Merge pull request #855 from plone/vale3-upgrade
Browse files Browse the repository at this point in the history
Upgrade Vale to v3
  • Loading branch information
stevepiercy authored Oct 10, 2024
2 parents 1404dec + 41cc43b commit 638a1f7
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 8 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,4 @@ jobs:
run: make test

- name: Run Vale
run: |
git clone https://github.com/errata-ai/Microsoft.git
cp -r ./Microsoft/Microsoft ./styles
VALEFILES=$(find ./docs/ -type f -name "*.md" -print)
vale --no-exit $VALEFILES
run: make vale VALEOPTS="--no-exit --minAlertLevel='warning'"
2 changes: 2 additions & 0 deletions .vale.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ Packages = Microsoft

[*]
BasedOnStyles = Vale, Microsoft
Microsoft.Contractions = suggestion
Microsoft.Units = suggestion
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ ALLSPHINXOPTS = -d $(BUILDDIR)/doctrees $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) .
# the i18n builder cannot share the environment and doctrees with the others
I18NSPHINXOPTS = $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) .
VALEFILES := $(shell find $(DOCS_DIR) -type f -name "*.md" -print)
VALEOPTS ?=

# Add the following 'help' target to your Makefile
# And add help text after each target name starting with '\#\#'
Expand Down Expand Up @@ -186,8 +187,8 @@ linkcheckbroken: bin/python ## Run linkcheck and show only broken links

.PHONY: vale
vale: bin/python ## Run Vale style, grammar, and spell checks
vale sync
vale --no-wrap $(VALEFILES)
bin/vale sync
bin/vale --no-wrap $(VALEOPTS) $(VALEFILES)
@echo
@echo "Vale is finished; look for any errors in the above output."

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ sphinx-sitemap
sphinx-togglebutton
sphinxcontrib-spelling
sphinxext-opengraph
vale==2.30.0
vale==3.7.1.0
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 638a1f7

Please sign in to comment.