Fix slate RichTextwidget to allow support slate extensions refs#6570

[nileshgulia1]

Closes #6570

[netlify]

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	5a3dbaf
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/67a64546eb426200085cfefa

[davisagli]

I glanced at this but I'm not familiar with slate extensions, so don't really feel competent to review it. @nileshgulia1 It would help if you could say a bit about what you're trying to do here or how to test it. The lack of an automated test also makes me more hesitant to click approve.

[nileshgulia1]

@davisagli Its something which we are also doing it for textBlock. slate-extensions just adds extra capabilities to slate wrapped components. To test this, you can create a RichText widget in your content type, try to create some lists(ul) with few li's, save the page and re-edit them, you see there is no way to get outside of lists, or actually there is no way to add anything else.
I've created a sample here(on edit ): https://demo.plone.org/test-richtext

Perhaps I should create some E2E tests also 🤔

[nileshgulia1]

There is a detached mode also but I think its for blocks not widgets.

[stevepiercy]

@nileshgulia1 I don't follow. I can use the up and down arrows to move between blocks.

Screen.Recording.2025-01-28.at.2.35.25.PM.mov

[davisagli]

@nileshgulia1 @stevepiercy I think I understand the problem better now:

• This is specifically a problem with the rich text widget, not the slate block. To test it, you have to add a rich text field to a content type, and edit there, not in a block.
• The problem is that when you're typing in a list, you would expect to be able to hit Enter a couple times to end the list. But this just creates new list items, and there's no obvious way to add text that is not in the list.

Do I have it right? If so, I'd suggest a different changelog entry here: "Fix typing Enter to end a list in the RichTextWidget." Using a slate extension for this is just an implementation detail, not the point of the change.

Unfortunately, I tested with this PR locally and it doesn't actually seem to fix the problem.

[nileshgulia1]

I'm curious as it does work for me with a backend different from plone-backend in this repo. There must be something happening either in content-type schema or slate.schema/policy addons. I will dig further into this weekend.

Screen.Recording.2025-01-29.at.2.28.31.PM.mov

[davisagli]

@nileshgulia1 Your video looks like what I would expect! I'll try to step through in the debugger in my local site later this week and see if I can tell why it didn't work for me.

[nileshgulia1]

I fixed the issue with inconsistency, htmlSlateWidget is used as richtext and we override this in our policy adddon. Thus, the same extension should be ported here as well.

I will write the cypress for this scenario.

[nileshgulia1]

-cc @davisagli

[davisagli]

@nileshgulia1 Thanks, now it does what I expected!

[nileshgulia1]

@sneridagh We can merge this please. Thank you.

[davisagli]

@nileshgulia1 Use .internal for changes that only involve tests. I updated it already.