Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideogram: App Improvements #71

Merged
merged 12 commits into from
Dec 6, 2018
Merged

Ideogram: App Improvements #71

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
db4efba
Update ideogram-styles.css
mtwichan Dec 4, 2018
44d8531
Remove unneccessary concat in DashIdeogram.react.js
mtwichan Dec 4, 2018
3c87a4f
PF & JP issue changes to app_ideogram.py
mtwichan Dec 4, 2018
1aec2a0
merge master to ideogram-review-fix
mtwichan Dec 4, 2018
d0099fd
Changed colors of app_ideogram.py
mtwichan Dec 4, 2018
95d1fb4
DDS Ideogram Repo app
mtwichan Dec 4, 2018
e88ecbd
Uploaded individual app, return to Dash-bio
mtwichan Dec 4, 2018
fc64f06
Fix homology inputs width for app_ideogram.py
mtwichan Dec 5, 2018
3d1702d
PEP8 app_ideogram.py
mtwichan Dec 6, 2018
192bc8b
Merge branch 'master' into ideogram-review-fix
mtwichan Dec 6, 2018
91c5084
Removed broken datasets from app_ideogram.py
mtwichan Dec 6, 2018
ff8095e
Rebuild dash-bio
mtwichan Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions assets/ideogram-style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,26 @@
}

.ideogram-column {
max-height: 78vh;
padding-left: 0.5%;
max-height: 83vh;
overflow-y: auto;
}

.ideogram-custom {
max-height: 78vh;
max-height: 83vh;
overflow-y: auto;
position: relative;
}

.ideogram-column-content {
width: 100%;
}

.ideogram-databox-parameters {
border: 1px solid #D1D1D1;
border-radius: 4px;
margin-top: 5%;
padding-left: 4%;
padding-top: 3%;
padding-bottom: 3%;
}
5 changes: 2 additions & 3 deletions src/lib/components/DashIdeogram.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,11 @@ export default class DashIdeogram extends Component {
setConfig() {
// Pass in all props into config except setProps
let config = omit(['setProps'], this.props);

// Event handlers
config.onDidRotate = this.onRotateHandler
config.onBrushMove = this.props.brush ? this.onBrushHandler : null
config.onLoad = this.onLoadHandler
config.container = '#ideogram-container' + '-' + this.props.id
config.container = '#ideogram-container-' + this.props.id

return config;
}
Expand Down Expand Up @@ -244,7 +243,7 @@ export default class DashIdeogram extends Component {
<div id={this.props.id} className={this.props.className} style={this.props.style}>
<div
{...omit(['setProps'], this.props)}
id={'ideogram-container' + '-' + this.props.id}
id={'ideogram-container-' + this.props.id}
onMouseOver={this.onMouseOverHandler}
></div>
</div>
Expand Down
Loading