Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken readonly feature in project and catalog controllers #1849

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 4, 2025

This fixes an issue with project/catalog CRDs that already exist in the API not being marked correctly as readonly.
isAlreadyExist check did not take into account the readonly status flag and during the subsequent reconcile
it was flipping the original readonly: true to readonly: false because project did exist in the API and ID was already synchronized.
Due to this i.e. deleting readonly default project was trying to delete the actual project from the API thus blocking CRD deletion and further service deployment cleanup.

Test Plan

Running controller locally on dev env

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@floreks floreks self-assigned this Feb 4, 2025
@floreks floreks added the bug-fix This pull request fixes a bug label Feb 4, 2025
@floreks floreks merged commit b793531 into master Feb 4, 2025
13 of 14 checks passed
@floreks floreks deleted the fix/controllers branch February 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants