fix: broken readonly feature in project and catalog controllers #1849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with project/catalog CRDs that already exist in the API not being marked correctly as readonly.
isAlreadyExist
check did not take into account thereadonly
status flag and during the subsequent reconcileit was flipping the original
readonly: true
toreadonly: false
because project did exist in the API and ID was already synchronized.Due to this i.e. deleting
readonly
default project was trying to delete the actual project from the API thus blocking CRD deletion and further service deployment cleanup.Test Plan
Running controller locally on dev env
Checklist