Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typing to service components #1853

Merged
merged 4 commits into from
Feb 5, 2025
Merged

add typing to service components #1853

merged 4 commits into from
Feb 5, 2025
+756 −689

Conversation

jsladerman
Copy link
Contributor

@jsladerman jsladerman commented Feb 5, 2025 •
edited
Loading

  • adds much more type safety to service components lists and details (closes PROD-3140)
  • we've run into bugs here in the past that would've been caught by TS, but this was harder to do before chore!: Remove deprecated components #1653 when app and service components shared code
  • shouldn't change any actual functionality outside of consolidating code

also adds console version label to the sidebar (closes PROD-3169)

@jsladerman jsladerman added enhancement New feature or request frontend Changes related to the frontend labels Feb 5, 2025
@jsladerman jsladerman requested a review from a team February 5, 2025 02:05
@linear Linear
Copy link

linear bot commented Feb 5, 2025

PROD-3140 add better typing to service component details screen

PROD-3169 Add console version to navbar

@jsladerman jsladerman merged commit 37c1917 into master Feb 5, 2025
12 checks passed
@jsladerman jsladerman deleted the jake/prod-3169-add-console-version-to-navbar branch February 5, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@floreks floreks floreks approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Changes related to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsladerman @floreks @maciaszczykm