Fix pipeline gate rerunning #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
force-pushed
the
pipeline-job-rerun
branch
2 times, most recently
from
5d5549c to
13672f4
Compare
maciaszczykm
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Should it be removed? Does it open PRs too often?
maciaszczykm
approved these changes
Feb 5, 2025
This logic was actually backwards, causing pipelines to repromo gates continuously until satisfied. the correct logic is to only reopen them if they haven't yet been opened during the promotion. Also added a test (which wasn't done originally for this to cut corners).
michaeljguarino
force-pushed
the
pipeline-job-rerun
branch
from
13672f4 to
b05ce2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic was actually backwards, causing pipelines to repromo gates continuously until satisfied. the correct logic is to only reopen them if they haven't yet been opened during the promotion. Also added a test (which wasn't done originally for this to cut corners).
Test Plan
unit tests
Checklist