Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cluster audit logs view to kubernetes dashboard #1861

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 6, 2025

Added audit logs table view to kubernetes dashboard.
image

Test Plan

Locally w/ dev env

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

Copy link

linear bot commented Feb 6, 2025

@floreks floreks added the enhancement New feature or request label Feb 6, 2025
@floreks floreks self-assigned this Feb 6, 2025
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been modified to take the gql fixes into account yet?

@floreks
Copy link
Member Author

floreks commented Feb 7, 2025

Yep, it's ready. I have updated the screenshot in the PR description.

cell: ({ getValue }) => <UserInfo user={getValue() ?? {}} />,
})

const columns = [userColumn, pathColumn, methodColumn, insertedAtColumn]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super NIT-y, but I think the order here should be [method, path, actor, timestamp]

@michaeljguarino michaeljguarino force-pushed the sebastian/prod-3068-add-ability-to-log-api-calls-from-kas-back-to-the-console branch from 7e0e0bb to 27df631 Compare February 11, 2025 19:29
@michaeljguarino michaeljguarino merged commit 5a0823b into master Feb 11, 2025
10 checks passed
@michaeljguarino michaeljguarino deleted the sebastian/prod-3068-add-ability-to-log-api-calls-from-kas-back-to-the-console branch February 11, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants