Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the inline option #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bernhard---H
Copy link

I removed everything from the template if inline=true is set, like in the example in the docs.

@josefguenther
Copy link

I would be very happy if this was merged... By the way, are you adding support for sideBySide?

@Bernhard---H
Copy link
Author

@josefguenther no, I'm not adding support for any other option, since the addon already supports all options of bootstrap-datetimepicker, except the ones that require special markup.

A workaround, until this gets merged:

// components/bootstrap-datetimepicker-inline/component.js
import BSDatetimePickerComponent from 'ember-bootstrap-datetimepicker/components/bs-datetimepicker';

export default BSDatetimePickerComponent.extend({
  inline: true
});
{{! components/bootstrap-datetimepicker-inline/template.hbs }}
{{yield}}

# Conflicts:
#	addon/components/bs-datetimepicker.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants