-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal petsc4py code for ksp #370
Conversation
… there is an error with the linear solver after some iterations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Enrico! This looks really good. Most comments are curiosity questions, me wanting to better understand what is going on.
Most critical is the failing installation of DarSIA including petsc4py. The style (black etc.) will sort out. I can take care of that once the installation is fixed.
Some comments on why we are not able to install petsc4py. I was able to make everything work using conda + create env + installing petsc with conda install (pip install inside the env does not work). Hypre and mumps are, by default, included in the conda installation of petsc. |
I removed petsc4py and cython from the requirements. Instead, now petsc4py (at least on github actions) is build in the build workflow, see #374 . The installation for Windows will not fully work from command line I fear, and not just using pip. I am trying therefore instead to set up a separate routine for that. Can you check, whether you can run the installation of petsc incl. hypre and mumps as done in the ci script? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I answered your points. But I just wanted to test the CI. I am not sure I did the review as it supposed to be.
Testing works but it took "30 minutes" to complete with the inclusion of hypre and mumps. We can just use native petsc solvers (replacing "hypre" with "icc" and mumps with the standard LU factorization), include petsc. So that the building test is passed and it takes way less time. However, the installation of mpi4py requires MPI being installed. This may cause problems to some users.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now! Thanks a lot!
Minimal code using petsc4py and ksp solver for linear systems.
Test add to test_wasserstein