-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonmatching grid tests #1334
base: develop
Are you sure you want to change the base?
Nonmatching grid tests #1334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I added some comments, and suggest to delete most of the documentation that reflect the development, rather than the result.
Main request: This function will be much more useful (also outside tests) if the user can controll the refinement process in fractures and interfaces. Please consider how this can be controlled by using parameters.
We should also make sure the geometry setup is directly tested, not just through the inclusion in higher-order tests. |
Note to selves after randomly meeting @keileg in the hallway: Make a test for testing the geometry itself. |
This look fairly good now. Let's try to do a final change in today's session: We see if we can move the actual mesh generation to |
Proposed changes
Issue: #1312
We created a new class to generate non-matching grids, which can handle cases with 0 to 2 orthogonal fractures. It returns a refined fracture set and a refined interface map. Its functionality is tested in test_fluid_mass_balance.py. The fluid mass problem, previously tested only on matching grids, is also tested with non-matching grids.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.