Merge pull request #117 from Noamshmueli/bugfix/hpa-version

fix HPA api version
pmint93 · Jun 12, 2024 · c19994c · c19994c
2 parents d34d68c + 9d421e4
commit c19994c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/charts/metabase/Chart.yaml b/charts/metabase/Chart.yaml
@@ -3,7 +3,7 @@ description:
   The easy, open source way for everyone in your company to ask questions
   and learn from data.
 name: metabase
-version: 2.15.7
+version: 2.15.8
 appVersion: v0.49.13
 maintainers:
   - name: pmint93

diff --git a/charts/metabase/templates/_helpers.tpl b/charts/metabase/templates/_helpers.tpl
@@ -35,6 +35,17 @@ Return the apiVersion of deployment.
 {{- end -}}
 {{- end -}}
 
+{{/*
+Return the apiVersion of hpa.
+*/}}
+{{- define "hpa.apiVersion" -}}
+{{- if semverCompare "<1.23-0" .Capabilities.KubeVersion.GitVersion -}}
+{{- print "autoscaling/v1" -}}
+{{- else if semverCompare ">=1.23-0" .Capabilities.KubeVersion.GitVersion -}}
+{{- print "autoscaling/v2" -}}
+{{- end -}}
+{{- end -}}
+
 {{/*
 Create the name of the service account to use
 */}}

diff --git a/charts/metabase/templates/hpa.yaml b/charts/metabase/templates/hpa.yaml
@@ -1,5 +1,5 @@
 {{- if .Values.hpa.enabled }}
-apiVersion: autoscaling/v2beta2
+apiVersion: {{ template "hpa.apiVersion" . }}
 kind: HorizontalPodAutoscaler
 metadata:
   name: {{ template "metabase.fullname" . }}