Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/metabase] Add autoMount SA and upgrade metabase version #119

Merged
merged 1 commit into from
Jun 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/metabase/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description:
The easy, open source way for everyone in your company to ask questions
and learn from data.
name: metabase
version: 2.15.6
appVersion: v0.49.12
version: 2.15.7
appVersion: v0.49.13
maintainers:
- name: pmint93
email: [email protected]
Expand Down
1 change: 1 addition & 0 deletions charts/metabase/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ spec:
priorityClassName: {{ .Values.priorityClass }}
{{- end }}
serviceAccountName: {{ template "metabase.serviceAccountName" . }}
automountServiceAccountToken: {{ .Values.automountServiceAccountToken }}
volumes:
{{- if or .Values.log4jProperties .Values.log4j2XML }}
- name: config
Expand Down
1 change: 1 addition & 0 deletions charts/metabase/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{{- if .Values.serviceAccount.create -}}
apiVersion: v1
kind: ServiceAccount
automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}
metadata:
name: {{ include "metabase.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
Expand Down
8 changes: 8 additions & 0 deletions charts/metabase/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ serviceAccount:
# The name of the service account to use.
# If not set and create is true, a name is generated using the fullname template
name:
# autoMount is deprecated in favor of automountServiceAccountToken
# If you want to disable auto mount of Service Account Token then you can set the value to false;
# https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#opt-out-of-api-credential-automounting
automountServiceAccountToken: false

resources:
{}
Expand All @@ -248,6 +252,10 @@ resources:
# cpu: 100m
# memory: 128Mi

# You can also opt out of automounting API credentials for a particular Pod;
# https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#opt-out-of-api-credential-automounting
automountServiceAccountToken: true

## Node labels for pod assignment
## ref: https://kubernetes.io/docs/user-guide/node-selection/
#
Expand Down
Loading