add support for host aliases #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add host aliases block to the deployment
update chart version
…t-aliases Update values.yaml
|
Greate idea. Seems like i need this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pmint93 I love this metabase helm chart!
Regarding the PR, I forked the repository, created a PR on my fork, merged it, and then opened a PR from master to master.
I wanted to add support for host aliases since I am working in an environment that doesn't have DNS resolving to a postgres instance and this PR should help me reach to that postgres instance using the host aliases. I believe that it will also help other users who will encounter the same scenario as I am facing.