Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod context security #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/metabase/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ The following table lists the configurable parameters of the Metabase chart and
| extraEnv | Mapping of extra environment variables | {} |
| envFrom | Mapping of extra environment variables from secret and/or configMap | [] |
| sidecars | Mapping of container sidecars for the main deployment | [] |
| securityContext | Security Context for the Metabase pod | {} |
| securityContext | Security Context for the Metabase container | {} |
| podSecurityContext | Security Context for the Metabase pod | {} |

The above parameters map to the env variables defined in [metabase](http://github.com/metabase/metabase). For more information please refer to the [metabase documentations](https://www.metabase.com/docs/v0.41/operations-guide/environment-variables.html).
3 changes: 3 additions & 0 deletions charts/metabase/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ spec:
{{- if .Values.sidecars }}
{{ toYaml .Values.sidecars | nindent 8 }}
{{- end }}
{{- if .Values.podSecurityContext}}
securityContext:
{{- .Values.securityContext | toYaml | nindent 8 }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be .Values.podSecurityContext ?

{{- with .Values.nodeSelector }}
nodeSelector:
{{ toYaml . | indent 8 }}
Expand Down
Loading