Metabase: Google Cloud SQL support

[tclift]

Add support for Google Cloud SQL through use of the Cloud SQL Auth proxy running as a sidecar.

This method supports the recommended Workload Identity method of authentication. It does not support using a specific service account credentials (JSON) file.

In case specific database provider support is not desirable in this chart, an alternative approach would be to allow arbitrary additional container support in the Deployment via values.yaml (perhaps along with an example for how to get Cloud SQL working with that approach).

[pmint93]

Great feature for GKE users 👍

Please also bump the chart version in Chart.yaml so it pass the checks and we can merge this PR

[tclift]

Thanks, chart version bumped.

By the way, I tested this by running chart-releaser-action locally using act, with the resulting release being uploaded to my fork. It might have been specific to the act environment, but I hit a bug with uses: helm/[email protected] (can't recall the details now). I upgraded it to 1.2.1 and hit this bug, which might be specific to using an SSH remote. Downgrading to 1.2.0 worked.

Which is to say... you should be safe to upgrade chart-releaser-action to 1.2.0 if you wanted :)

[pmint93]

@tclift Thanks a lot for your detailed information.

Btw, the test currently failed due to "missing starting space in comment" in values.yaml:68

[tclift]

Sorry about that. I've fixed it up.

FWIW, I disagree with the linter. Space-after-hash is fine for human readable comments, but the line in question was a commented out option. The user should be able to remove the hash to enable the option, without being concerned about indentation. I can see now that other options in the file have a space-after-hash for the same thing... it does seem like capitulation to an unhelpful linting rule.

I also worked out how to get the linter running locally:

docker run -it --rm -v `pwd`:/repo -w /repo quay.io/helmpack/chart-testing:latest ct lint

(this might be useful for the README or CONTRIBUTING)

[pmint93]

I agree with you that space-after-hash is just fine for human readable. But I think the reason for that is people usually use IDE, code editor shortcut to commenting out like Ctrl ( or Command) + / so it automatically add/remove a hash and a space