Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/metabase] : Fixing servicemonitor according to prometheus and k8s spec #95

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Conversation

William-LP
Copy link
Contributor

Hello !

I'm trying to install the metabase chart but I run into this error when enabling the serviceMonitor as below :

metabase:
  monitoring:
    enabled: true
    serviceMonitor:
      enabled: true
    port: 9191

Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(ServiceMonitor.spec.selector): unknown field "app" in com.coreos.monitoring.v1.ServiceMonitor.spec.selector, ValidationError(ServiceMonitor.spec.selector): unknown field "release" in com.coreos.monitoring.v1.ServiceMonitor.spec.selector]

As per official kubernetes and prometheus spec, the matchLabels field is missing. This PR provides a fix.

I've tested the code and it works like a charm ! :)

@pmint93
Copy link
Owner

pmint93 commented Jan 7, 2024

Thanks a lot !

@pmint93 pmint93 merged commit 108a277 into pmint93:master Jan 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants