Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pgbouncer): ability to disable service-account creation if alrea… #97

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

OlivierCharuel
Copy link
Contributor

@OlivierCharuel OlivierCharuel commented Jan 25, 2024

This PR allows usage of the service-account features without creating it from this chart (i.e. avoid duplicate declaration, when the SA is already present in the namespace)

Thonks,

@pmint93
Copy link
Owner

pmint93 commented Jan 31, 2024

@OlivierCharuel the best practice is to use a field named exsistingServiceAccountName: "", then use the name if it present, otherwise use the default name. By this you can not only prevent the duplication but also use difference name for the existing service account

@OlivierCharuel
Copy link
Contributor Author

@pmint93 Thanks for the advice, updated/tested my code according to your preco.

Copy link
Owner

@pmint93 pmint93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution !

@pmint93 pmint93 merged commit dd29584 into pmint93:master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants