V4.2rc2 #509
Closed
V4.2rc2 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few missing data types and APIs. Minor correction in the Fabric chapter. Signed-off-by: Ralph Castain <[email protected]>
Update the Python bindings to track the Standard
Signed-off-by: Ralph Castain <[email protected]> Co-authored-by: Josh Hursey <[email protected]>
First cut at acknowledgements
Signed-off-by: Joshua Hursey <[email protected]>
Acknowledgements: Fix typo, sync with v3.2
Signed-off-by: Ralph Castain <[email protected]> Co-authored-by: Josh Hursey <[email protected]>
Signed-off-by: Joshua Hursey <[email protected]>
Replace the bitarray types in Python bindings with simple integer lists for ease of use/translation. Cleanup some missing functions. Add PMIX_EXTERNAL_PROGRESS attribute and PMIx_Progress API so that a host can externally progress the PMIx library. This is less onerous than requiring the host to also adopt libevent and provide an event base. Deprecate the PMIX_EVENT_BASE attribute. I had forgotten about the external progress promise until someone pointed it out to me. Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Update the check-attr-refs.py script to ignore PMIX_ATTR_UNDEF as it cannot be referenced. Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Refer instead to "max procs that can be simultaneously executing" Signed-off-by: Ralph Castain <[email protected]>
Updates to Python bindings and missed API
Provide the ability to request pointers to values, filling in of a provided value struct address, as well as the default return of a newly malloc'd struct. Clarify that "success" means the data was returned in the form requested - do not return it as something different. Remove the "slot" definition per WG discussion Signed-off-by: Ralph Castain <[email protected]>
Final touchups to PMIx_Get and PMIx_server_init attributes
The pmix_server_fencenb_fn_t upcall function cannot return "operation succeeded" as that would prevent the return of any collected data. Signed-off-by: Ralph Castain <[email protected]>
Fix copy/paste error
Turns out we do need this in the standard Signed-off-by: Ralph Castain <[email protected]>
Restore PMIX_EVENT_BASE attribute
Signed-off-by: Ralph Castain <[email protected]>
Minor touchups and additions
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit c9bf5df)
Add reserved prefixes for regular expressions and explain that such prefixes are required to be present. Expand on explanation of refresh cache behavior and required keys. Add new compressed byte object data type. Signed-off-by: Ralph Castain <[email protected]>
Per the provided comments Signed-off-by: Ralph Castain <[email protected]>
Looks good to me. Signed-off-by: Ralph Castain <[email protected]> Co-authored-by: Josh Hursey <[email protected]>
Signed-off-by: Ralph Castain <[email protected]> Co-authored-by: Josh Hursey <[email protected]>
Minor cleanups and clarifications
Fix a stray period typo
* `PMIX_LOCALITY` is already in the v4 deprecation list * Only declare `PMIX_SERVER_SCHEDULER` once. Consolidate the definition. * Fixes #264 Signed-off-by: Joshua Hursey <[email protected]>
The PMIx convenience macros are frequently used. However, several of them are difficult to implement as pure macros, or even as static inline functions. In the current implementation, these were backed by public functions outside of the Standard, thus making them less desirable. This RFC replaces those specific macros with their functional equivalent, thereby providing Standard APIs for these utilities. The corresponding macros are now marked as "deprecated". Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Reference API replacements for macros Add missing PMIx_Info_load and PMIx_Info_xfer API replacements for their respective macros. Update all references to deprecated macros with APIs. Signed-off-by: Ralph Castain <[email protected]>
Allow the macro to operate on the global "environ" array as well as user-provided arrays. Signed-off-by: Ralph Castain <[email protected]>
Convert several macros to APIs
Signed-off-by: Joshua Hursey <[email protected]>
* "debug-files" contains a sorted list of various declarations Output example: ``` ====> Display Stats Valid | Deprecated | Removed | Description ------+------------+---------+-------------- 179 | 2 | 0 | APIs 457 | 44 | 30 | Attributes 292 | 43 | 25 | Constants 141 | 12 | 0 | Macros 44 | 0 | 0 | Structs ------+------------+---------+-------------- 1113 | 101 | 55 | Totals ``` Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit ca3860e)
* Remove the reference to the stale TravisCI * Replace the reference with the GitHub Action badge Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit c182790)
A few Infrastructure fixes
* The prior mechanism put the marker in the margin, but was not working consistently. So instead put them in-line by the provisional text. Signed-off-by: Joshua Hursey <[email protected]>
Signed-off-by: Joshua Hursey <[email protected]>
v4: Fix Provisional Markers
PMIx_Info_load will set the info value to true.
PMIX_Info_load BOOL with NULL sets value to true
Clarify that PMIX_NODE_SIZE counts processes that have not (or will not) call pmix
…e a pmix_byte_object_t * Signed-off-by: David Solt <[email protected]> (cherry picked from commit 8554707) (cherry picked from commit 46c1459)
Change type of key parameter to PMIx_Get_nb to match PMIx_get
…_type@v4 Issue421/pmix iof cbfunc arg type@v4
Signed-off-by: Aurélien Bouteiller <[email protected]>
Signed-off-by: Aurélien Bouteiller <[email protected]>
|
I pushed the changes directly instead of doing a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final prep changes for v4.2rc2
Tracking issue #508