-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather System Implementation #6477
base: minor-next
Are you sure you want to change the base?
Conversation
There should be an option in the config and a method to disable the weather cycle and an event for when weather changes |
@@ -106,6 +106,7 @@ public static function registerCorePermissions() : void{ | |||
self::registerPermission(new Permission(Names::COMMAND_UNBAN_IP, l10n::pocketmine_permission_command_unban_ip()), [$operatorRoot]); | |||
self::registerPermission(new Permission(Names::COMMAND_UNBAN_PLAYER, l10n::pocketmine_permission_command_unban_player()), [$operatorRoot]); | |||
self::registerPermission(new Permission(Names::COMMAND_VERSION, l10n::pocketmine_permission_command_version()), [$everyoneRoot]); | |||
self::registerPermission(new Permission(Names::COMMAND_WEATHER, "Changing the weather in the world")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a direct translation should be created l10n::pocketmine_permission_command_weather()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to change the permission to the correct word
Why not using the world's gamerule? It's not a plugin, you don't add as many config files as there are systems. |
Introduction
Adding
Weather System
Changes
API changes
Added
WeatherCommand
Added permission
pocketmine.command.weather
Added file in src/world/weather
Added method in src/Server.php
Added method in src/world/World.php
getWeatherManager
Requires translations:
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)