Weather System Implementation #6477
Draft
+285
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnosTx
changed the title
|
There should be an option in the config and a method to disable the weather cycle and an event for when weather changes |
| @@ -106,6 +106,7 @@ public static function registerCorePermissions() : void{ | |||
| self::registerPermission(new Permission(Names::COMMAND_UNBAN_IP, l10n::pocketmine_permission_command_unban_ip()), [$operatorRoot]); | |||
| self::registerPermission(new Permission(Names::COMMAND_UNBAN_PLAYER, l10n::pocketmine_permission_command_unban_player()), [$operatorRoot]); | |||
| self::registerPermission(new Permission(Names::COMMAND_VERSION, l10n::pocketmine_permission_command_version()), [$everyoneRoot]); | |||
| self::registerPermission(new Permission(Names::COMMAND_WEATHER, "Changing the weather in the world")); | |||
There was a problem hiding this comment.
a direct translation should be created l10n::pocketmine_permission_command_weather()
There was a problem hiding this comment.
I forgot to change the permission to the correct word
|
Why not using the world's gamerule? It's not a plugin, you don't add as many config files as there are systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Adding
Weather SystemChanges
API changes
Added
WeatherCommandAdded permission
pocketmine.command.weatherAdded file in src/world/weather
Added method in src/Server.php
Added method in src/world/World.php
getWeatherManagerRequires translations:
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)