Release 5.23.0 #6561
Merged
Release 5.23.0 #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11769186885
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11802296296
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11824307499
Co-authored-by: ipad54 <[email protected]> Co-authored-by: Dylan T. <[email protected]>
…ks/VanillaItems (#6498) Use reflection to locate BlockTypeIds and ItemTypeIds for VanillaBlocks/VanillaItems Since BlockTypeIds and ItemTypeIds are derived from VanillaBlocks and VanillaItems respectively anyway (they only exist to allow identifying blocks/items without having to create instances of them), this hack is probably OK, and reduces the chances of mistakes. Previously it was explored to have these IDs generated by auto-incrementing in VanillaBlocks/Items and have the constants generated that way, but this proved to be too problematic because of unstable diffs no matter how we chose to sort the elements. See #6313 for previous research on the subject. This is obviously not a desirable hack to keep long-term. In the future it will probably make sense to redesign VanillaBlocks like so: enum VanillaBlocks { ... } VanillaBlocks::STONE (the type ID) VanillaBlocks::STONE->new() (to create a block) However, more research is needed on this, as I'd prefer not to make block creation any more verbose.
This will be useful for future block additions
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11862895039
…item and block (#4683) This allows, for example, banning the usage of spawn eggs, without preventing opening of doors, without the need for item ID whitelists. It also allows customizing the behaviour of item and block interactions when sneaking - it's now possible to force spawn eggs to work when sneaking, or force containers to open. Finally, this also allows preventing any interaction at all without preventing block placement (by setting both to false). Since cancelling the event will typically prevent placement too (which might not be desired). Side note: Blocks are now always synced when right-clicking on a block. This differs from the previous behaviour, where the blocks were only synced when the action "failed". However, since this change introduces a situation where the action may succeed but have different results than the client expects, it's best to just always sync blocks in this situation. Fixes #3267
Support for more advanced stuff like NBT copying wasn't added in this PR, as the NBT used by PM is currently an inconsistent mess and doesn't play nice with vanilla. In the interests of avoiding this mess propagating, it's been left for another time. Adds PlayerEntityPickEvent a la PlayerBlockPickEvent and Entity->getPickedItem().
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11865975725
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11866065217
Co-authored-by: Dylan T. <[email protected]>
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11874902000
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11904511045
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11924942897
… to the main server process (#5273) Support for this was introduced in PHP 8.0, though not mentioned in any changelog: php/php-src#5777 This simplifies the subprocess handling considerably. However, there is a potential for problems if PHP generates any E_* errors, since these get written to STDOUT as well. To avoid error messages being treated as a command, a hash is attached to each IPC message, seeded with an incrementing counter. This prevents error messages causing command replays or unintended commands. Unfortunately, PHP doesn't support binding pipes other than stdin/stdout/stderr on Windows for the child process, so we have to use stdout for this. In the future, if it becomes possible, a dedicated pipe for the purpose should be introduced. We'd need something like php://fd/<number> to work on Windows.
this is dodgy and we shouldn't rely on it long term. relates to #6524
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11964819241
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/11989715327
Co-authored-by: Dylan K. Taylor <[email protected]>
Co-authored-by: Dylan T. <[email protected]>
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12111121061
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12131296321
the issues that led to the need for a fork have been addressed in the 5.0.0 release.
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12151373979
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
dktapps
added
Category: API
ipad54
reviewed
Dec 5, 2024
ipad54
reviewed
Dec 5, 2024
plugins shouldn't be using these, but since it's not marked as internal, we can't be sure.
ipad54
approved these changes
Dec 5, 2024
|
Draft release 5.23.0 has been created for commit ea8f971. Please review and publish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all changes from minor-next as of December 5th
!!!! DO NOT squash merge this PR !!!!