Make Background disposable

pmndrs · Mar 2, 2024 · 1979f2e · 1979f2e
1 parent f6c1bf5
commit 1979f2e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/passes/ClearPass.ts b/src/passes/ClearPass.ts
@@ -70,6 +70,8 @@ export class ClearPass extends Pass {
 		this.backgroundScene = new Scene();
 		this.backgroundScene.add(this.background);
 
+		this.disposables.add(this.background);
+
 	}
 
 	/**

diff --git a/src/utils/Background.ts b/src/utils/Background.ts
@@ -16,6 +16,7 @@ import {
 	WebGLRenderer
 } from "three";
 
+import { Disposable } from "../core/Disposable.js";
 import { BackgroundMaterial } from "../materials/BackgroundMaterial.js";
 import { SkyBoxMaterial } from "../materials/SkyBoxMaterial.js";
 import { ClearValues } from "./ClearValues.js";
@@ -31,7 +32,7 @@ const matrix4 = /* @__PURE__ */ new Matrix4();
  * @internal
  */
 
-export class Background extends Group {
+export class Background extends Group implements Disposable {
 
 	/**
 	 * A sky box.
@@ -189,4 +190,11 @@ export class Background extends Group {
 
 	}
 
+	dispose(): void {
+
+		this.skyBox.material.dispose();
+		this.background.material.dispose();
+
+	}
+
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,6 +70,8 @@ export class ClearPass extends Pass { @@
     		this.backgroundScene = new Scene();
     		this.backgroundScene.add(this.background);
+    		this.disposables.add(this.background);
     	}
     	/**
@@ Expand Down @@