-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): multiple redos at once with proxyWithHistory #354
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/valtio/7wLQxXhQsfCgs3AcGiBUJEx7fAKk |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eaa96e4:
|
Size Change: +17 B (0%) Total Size: 34.5 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this code makes just 1 snapshot.
so you can change code like below
// fireEvent.click(getByText('inc'))
// fireEvent.click(getByText('inc'))
await waitFor(() => fireEvent.click(getByText("inc")));
await waitFor(() => fireEvent.click(getByText("inc")));
wow! thanks so much!! |
eaa96e4 passes the tests. I'm not 100% sure if there are any other cases that this can't handle, but let's go with this for now. |
close #323