DHW-related verification items development #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
design/dhw_tank_temperature.md
Outdated
| @@ -0,0 +1,96 @@ | |||
| # Control Verification Algorithm -- DHW_tank_temperature | |||
There was a problem hiding this comment.
@lymereJ
I added these markdown documents for your review. I plan to delete these after review.
lymereJ
requested changes
Aug 26, 2024
There was a problem hiding this comment.
@lymereJ
I'll delete all the files in the demo/hpwh_demo, if these shouldn't be included. I included these for your review purpose.
lymereJ
requested changes
Aug 27, 2024
lymereJ
changed the base branch from
develop
to
commercial_prototypes_building_models
lymereJ
reviewed
Aug 27, 2024
lymereJ
approved these changes
Aug 27, 2024
yunjoonjung-PNNL
merged commit c6772da
into
commercial_prototypes_building_models
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to develop 2 dhw related verification items. I made this draft PR for Jeremy's review.