Use #if defined instead of #if and turn off -Werror for debug builds #68
Conversation
|
Also this is a +1 for #52 |
|
I will PR into this with CMake suggestion. Still not sure why tests are failing on Newell + Ascent. Noteably two different tests are failing. |
cameronrutherford
force-pushed
the
fix/preprocess-if
branch
from
f2de2e0
to
a86b5a5
Compare
cameronrutherford
requested review from
bjpalmer,
william-smith-pnnl and
wperkins
and removed request for
william-smith-pnnl
|
Newell and Ascent are still failing so if someone can take a look into those failures then I am happy to merge |
|
Since this seems to have gotten lost in the comments - tests are failing on Newell and Ascent. Please fix |
|
cameronrutherford
dismissed stale reviews from bjpalmer and themself
via
4226902
|
I just ran this branch on deception and tests 20 and 21 are passing. These were the ones that you were reporting as failing, correct? I'm only seeing failures for 17,18,19. |
Remember we still are skipping some tests in CI per #43 and #3, which @jaelynlitz is also helping resolve. I think 17,18,19 are all skipped, and so you should see Deception tests passing as is reflected in PR status. You will only see test failures on Ascent and Newell, as is reflected in GitHub commit status. |
* Update CMakeLists.txt with macos specific compile flags * Apply pre-commmit fixes --------- Co-authored-by: cameronrutherford <[email protected]>
cameronrutherford
force-pushed
the
fix/preprocess-if
branch
from
4226902
to
b394b7f
Compare
cameronrutherford
added this to the 1.6.1 Python bindings + Documentation Release milestone
#ifdoes not work correctly on Mac so switching to#if defined. Noticed this behavior for#if (EXAGO_ENABLE_IPOPT || EXAGO_ENABLE_HIOP)so replaced it with#if defined EXAGO_ENABLE_IPOPT || defined EXAGO_ENABLE_HIOP.Also removed the
-Werrorflag for debug builds.sprintfis depecreated for clang and so-Werrorflag results in zillions of errors. Note that the error is thrown not only forsprintfin ExaGO code, but also if it is any dependency library. Need to tackle this through a separate issue so turning off the-Werrorfor now.