Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New templates Heat Pump installation #150

Merged
merged 29 commits into from
Aug 24, 2023
Merged

New templates Heat Pump installation #150

merged 29 commits into from
Aug 24, 2023

Conversation

sudhacheran
Copy link
Collaborator

  1. Addition of two new templates
  • Ductless Heat Pump Installation
  • Central Ducted Split Heat Pump Installation
  1. File upload - Feature added

@sudhacheran
Copy link
Collaborator Author

sudhacheran commented Aug 15, 2023 •
edited
Loading

This includes changes for the following Issues

  1. Improve RadioInput label Improve RadioInput label #154
  2. Input Hints Input Hints #153
  3. Uploadable PhotoInput Uploadable PhotoInput #151
  4. Back button styling Back button styling #146
  5. File Upload - New Feature File Upload - New Feature #138

@sudhacheran
This includes changes for the following Issues
22101f1 
Improve RadioInput label Improve RadioInput label #154
Input Hints Input Hints #153
Uploadable PhotoInput Uploadable PhotoInput #151
Back button styling Back button styling #146
@sudhacheran
lint fix and changes from template review
ff714b9
@sudhacheran
Hint in Number Input
a76d92d
@sudhacheran
Copy link
Collaborator Author

sudhacheran commented Aug 18, 2023 •
edited
Loading

Fix for Issue: Append a pdf to a project report #155

  • Tested the changes in Andriod, iPad (iOS) and Mac.

Code change with react-pdf for rendering pdf within "printsection"

Attaching sample report - from Mac
Job1-doe_workflow_central_ducted_split_heat_pump-report.pdf

charliepnnl
charliepnnl reviewed Aug 19, 2023
View reviewed changes
src/components/store.tsx Outdated Show resolved Hide resolved
src/components/store.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/store.tsx Outdated Show resolved Hide resolved
src/components/file_input.tsx Outdated Show resolved Hide resolved
src/components/file_input_wrapper.tsx Show resolved Hide resolved
src/components/file_renderer.tsx Outdated Show resolved Hide resolved
src/components/file_renderer.tsx Outdated Show resolved Hide resolved
src/components/file_renderer_wrapper.tsx Outdated Show resolved Hide resolved
src/templates/doe_workflow_central_ducted_split_heat_pump.mdx Show resolved Hide resolved
This was linked to issues Aug 23, 2023
File Upload - New Feature #138
Closed
Append a pdf to a project report #155
Closed
charliepnnl
charliepnnl previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@charliepnnl charliepnnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments that need to be addressed.

src/templates/doe_workflow_central_ducted_split_heat_pump.mdx Outdated Show resolved Hide resolved
src/templates/doe_workflow_central_ducted_split_heat_pump.mdx Outdated Show resolved Hide resolved
src/templates/doe_workflow_central_ducted_split_heat_pump.mdx Outdated Show resolved Hide resolved
src/templates/doe_workflow_ductless_heat_pump.mdx Show resolved Hide resolved
@charliepnnl
Copy link
Contributor

I tested the two templates by uploading all photos and verified they all worked in the report.

@sudhacheran
Copy link
Collaborator Author

sudhacheran commented Aug 24, 2023 •
edited
Loading

Following changes will be merged

  1. Addition of two new templates
  • Ductless Heat Pump Installation
  • Central Ducted Split Heat Pump Installation
  1. File upload - Feature added
  2. PDF renderer for attaching PDF content to the report
  • Tested the changes in Mac Book (Chrome & Safari), Android (Samsung - Chrome) and iOS (iPad - Chrome & Safari).

@sudhacheran sudhacheran merged commit f106738 into main Aug 24, 2023
2 checks passed
@sudhacheran sudhacheran deleted the new_templates_heatpump_installation branch August 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliepnnl charliepnnl charliepnnl left review comments

@mvgeorgescu mvgeorgescu mvgeorgescu approved these changes

@jackcruz53 jackcruz53 Awaiting requested review from jackcruz53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Append a pdf to a project report File Upload - New Feature
3 participants
@sudhacheran @charliepnnl @mvgeorgescu