Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IEER calculation through interpolation for multistage units (Part II) #126

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Feb 27, 2025

Supersedes #121 and #124. The changes in this PR are functional but the code needs to be cleaned-up before merging.

@lymereJ lymereJ changed the title Mult curves dx eqp Implement IEER calculation through interpolation for multistage units (Part II) Feb 27, 2025
@lymereJ
Copy link
Collaborator Author

lymereJ commented Feb 27, 2025

black has not been applied, but unit test run successfully locally.

@lymereJ
Copy link
Collaborator Author

lymereJ commented Mar 3, 2025

@aowabinr @wanhanlong1130 - Ok, tests are passing and I took a pass at doing some cleanup and adding docs. Please review it when you have time.

@wanhanlong1130
Copy link
Collaborator

@lymereJ I saw you blocked control_power_unit, do we need to add it to the class?

@wanhanlong1130
Copy link
Collaborator

unitarydirectexpansion.py, line 190, I suggest change "aed, self.aew, ect, lct = self.get_rated_temperatures()" to "_, self.aew, ect, _= self.get_rated_temperatures()" since aed and lct are not used.

@lymereJ lymereJ closed this Mar 4, 2025
@lymereJ lymereJ reopened this Mar 4, 2025
@wanhanlong1130
Copy link
Collaborator

test_unitarydirectexpansion.py, line 380, "assert abs(set_of_curves[0].evaluate(19.44, 35) - 0.99) < 0.011" should that be "<0.001"?

@lymereJ
Copy link
Collaborator Author

lymereJ commented Mar 4, 2025

@lymereJ I saw you blocked control_power_unit, do we need to add it to the class?

We can add it, I wanted to keep it simple for now since this is mostly for the AHRI test.

unitarydirectexpansion.py, line 190, I suggest change "aed, self.aew, ect, lct = self.get_rated_temperatures()" to "_, self.aew, ect, _= self.get_rated_temperatures()" since aed and lct are not used.

Thanks! I'll make the change.

test_unitarydirectexpansion.py, line 380, "assert abs(set_of_curves[0].evaluate(19.44, 35) - 0.99) < 0.011" should that be "<0.001"?

I'm not sure if it'd pass. Let me try it locally and if it does, I'll make that change as well.

@lymereJ
Copy link
Collaborator Author

lymereJ commented Mar 4, 2025

Comments were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants