-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IEER calculation through interpolation for multistage units (Part II) #126
base: develop
Are you sure you want to change the base?
Conversation
…tric for units having discrete stages/speeds (use multiple sets of curves).
|
@aowabinr @wanhanlong1130 - Ok, tests are passing and I took a pass at doing some cleanup and adding docs. Please review it when you have time. |
@lymereJ I saw you blocked control_power_unit, do we need to add it to the class? |
unitarydirectexpansion.py, line 190, I suggest change "aed, self.aew, ect, lct = self.get_rated_temperatures()" to "_, self.aew, ect, _= self.get_rated_temperatures()" since aed and lct are not used. |
test_unitarydirectexpansion.py, line 380, "assert abs(set_of_curves[0].evaluate(19.44, 35) - 0.99) < 0.011" should that be "<0.001"? |
We can add it, I wanted to keep it simple for now since this is mostly for the AHRI test.
Thanks! I'll make the change.
I'm not sure if it'd pass. Let me try it locally and if it does, I'll make that change as well. |
Comments were addressed. |
Supersedes #121 and #124. The changes in this PR are functional but the code needs to be cleaned-up before merging.