Add is_tolerance_fail method for Section 5 to 6 #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjoonjung-PNNL
approved these changes
Jan 22, 2024
weilixu
reviewed
Jan 24, 2024
| def is_tolerance_fail(self, context, calc_vals=None, data=None): | ||
| total_hours_compared = calc_vals["total_hours_compared"] | ||
| total_hours_matched = calc_vals["total_hours_matched"] | ||
| return std_equal(total_hours_matched, total_hours_compared) |
There was a problem hiding this comment.
- put the
is_tolerance_failafterget_fail_msgbecause the function is called afterget_fail_msg. - We do not need tolerance check for integers.
|
Thanks Weili for these valuable comments to help me learn. I have addressed all of them. @weilixu |
|
I am seeing many failures this time, and most of them are due to the precision issue - we may need to hold this update in the tolerance branch a little while until the decimal points are implemented. |
Jiarongx-Xie
commented
Feb 9, 2024
| ) | ||
| return calc_vals["wwr_b"] == min(calc_vals["wwr_p"], WWR_THRESHOLD) | ||
|
|
||
| def is_tolerance_fail(self, context, calc_vals=None, data=None): |
There was a problem hiding this comment.
@weilixu Hi Weili, is this an exception where both values are user inputs?
Jiarongx-Xie
commented
Feb 9, 2024
| skylight_roof_ratio_p = calc_vals["skylight_total_roof_ratio_p"] | ||
| return skylight_roof_ratio_b == skylight_roof_ratio_p | ||
|
|
||
| def is_tolerance_fail(self, context, calc_vals=None, data=None): | ||
| skylight_roof_ratio_b = calc_vals["skylight_roof_ratio_b"] | ||
| skylight_roof_ratio_p = calc_vals["skylight_total_roof_ratio_p"] | ||
| return std_equal(skylight_roof_ratio_b, skylight_roof_ratio_p) |
There was a problem hiding this comment.
@weilixu is this an exception where both values are user inputs?
Jiarongx-Xie
force-pushed
the
is_tolerance_fail_section_5_to_6
branch
from
f883b71
to
88299e8
Compare
…et-checking-tool into is_tolerance_fail_section_5_to_6 # Conflicts: # rct229/rulesets/ashrae9012019/section5/section5rule10.py # rct229/rulesets/ashrae9012019/section5/section5rule12.py # rct229/rulesets/ashrae9012019/section5/section5rule19.py # rct229/rulesets/ashrae9012019/section5/section5rule20.py # rct229/rulesets/ashrae9012019/section5/section5rule27.py # rct229/rulesets/ashrae9012019/section5/section5rule4.py # rct229/rulesets/ashrae9012019/section5/section5rule6.py # rct229/rulesets/ashrae9012019/section5/section5rule8.py
…et-checking-tool into is_tolerance_fail_section_5_to_6
…et-checking-tool into is_tolerance_fail_section_5_to_6
…et-checking-tool into is_tolerance_fail_section_5_to_6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the is_tolerance_fail method addition from section 5 to 6. Thanks!